feat(one-app-dev-cdn): pass use-host flag (#138)

americanexpress · May 13, 2020 · b7202ca · b7202ca
1 parent 4aba8ec
commit b7202ca
Show file tree

Hide file tree

Showing 7 changed files with 206 additions and 187 deletions.
diff --git a/__tests__/server/__snapshots__/index.spec.js.snap b/__tests__/server/__snapshots__/index.spec.js.snap
@@ -6,6 +6,7 @@ Array [
   "version",
   "m",
   "use-middleware",
+  "use-host",
 ]
 `;
 

diff --git a/__tests__/server/config/env/__snapshots__/argv.spec.js.snap b/__tests__/server/config/env/__snapshots__/argv.spec.js.snap
@@ -32,6 +32,17 @@ Array [
 `;
 
 exports[`argv config has development options and defaults 4`] = `
+Array [
+  "use-host",
+  Object {
+    "default": false,
+    "describe": "use req.headers.host instead of localhost for one-app-dev-cdn",
+    "type": "boolean",
+  },
+]
+`;
+
+exports[`argv config has development options and defaults 5`] = `
 Array [
   "log-format",
   Object {
@@ -47,7 +58,7 @@ Array [
 ]
 `;
 
-exports[`argv config has development options and defaults 5`] = `
+exports[`argv config has development options and defaults 6`] = `
 Array [
   "log-level",
   Object {
@@ -64,7 +75,7 @@ Array [
 ]
 `;
 
-exports[`argv config has development options and defaults 6`] = `
+exports[`argv config has development options and defaults 7`] = `
 Array [
   Array [
     Array [

diff --git a/docs/api/server/Cli-Commands.md b/docs/api/server/Cli-Commands.md
@@ -166,6 +166,7 @@ npm run build:sample-modules [--] [--archive-built-artifacts]
 | `--root-module-name`  | Name of the [Holocron Module] that serves as the entry point to your application. |
 | `--module-map-url`  | Remote Module Map URL for [`one-app-dev-cdn`] to proxy. *For Development.* |
 | `--use-middleware` | Apply a custom middleware configuration for [`one-app-dev-proxy`]. *For Development.* |
+| `--use-host` | Use `req.headers.host` instead of `localhost`. Passed as true or false to [`one-app-dev-cdn`]. *For Development.* |
 
 #### Environment Variables
 
@@ -214,4 +215,4 @@ Please see the [Environment Variables](./Environment-Variables.md) API docs.
 [Jest]: https://jestjs.io/
 [ESLint]: https://eslint.org/
 [Integration Test Suite]: ../../../__tests__/integration/README.md
-[Express Middleware]: http://expressjs.com/en/guide/writing-middleware.html#writing-middleware-for-use-in-express-apps
+[Express Middleware]: http://expressjs.com/en/guide/writing-middleware.html#writing-middleware-for-use-in-express-apps