Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rails to 7.2.1 #3423

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Upgrade Rails to 7.2.1 #3423

merged 3 commits into from
Sep 13, 2024

Conversation

CodeSonia
Copy link
Contributor

What

Upgrade Static application to Rails 7.2.1

Trello card

Why

To keep the Static application up-to-date with the latest Rails version, incorporating recent bug fixes and security updates.

@CodeSonia CodeSonia changed the title Upgrade rails to 7.2.1 Upgrade Rails to 7.2.1 Aug 30, 2024
Copy link
Contributor

@beccapearce beccapearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
One non-blocking comment :)

@@ -46,7 +46,7 @@
# config.i18n.raise_on_missing_translations = true

# Annotate rendered view with file names.
# config.action_view.annotate_rendered_view_with_filenames = true
config.action_view.annotate_rendered_view_with_filenames = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this line of code uncommented as part of the upgrade suggestion. The idea was to make it easier for developers to debug by adding comments in HTML to show which view template was responsible for rendering a specific section of a page.

If this becomes too noisy, we could comment this line of code!

Updated config files:
- bin/setup
- application.rb
- development.rb
- production.rb
- test.rb
- filter_parameter_logging.rb

Created new files following the rails app:update:
- bin/brakeman
- bin/rubocop
- new_framework_defaults_7_2.rb
- 404, 406, 422, 500 htmls
- icon png & svg
- robots.txt
@beccapearce beccapearce merged commit 6fc79e2 into main Sep 13, 2024
11 checks passed
@beccapearce beccapearce deleted the upgrade-rails-to-7.2.1 branch September 13, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants