Extract the error_summary component from government-frontend #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickColley
reviewed
Jan 10, 2018
| beforeEach(function () { | ||
| element = $( | ||
| '<div ' + | ||
| 'class="app-c-error-summary" ' + |
There was a problem hiding this comment.
These tests should be failing
There was a problem hiding this comment.
Actually nevermind, it'd be nice to be consistent but they are just JavaScript so make sense to be passing.
There was a problem hiding this comment.
Everything other than the old app-c stuff here looks good 👍
There was a problem hiding this comment.
Fixed.
The JavaScript tests weren't failing because the module is bound to the js-error-summary__link and isn't app- or gem- dependent.
We should use gem- here anyway for consistency.
There was a problem hiding this comment.
Good example of not binding to presentational classes 👍
We’d like to use this in email-alert-frontend https://trello.com/c/HSre7K10/453-style-the-mvp-email-collection-page-needed-by-jan
tuzz
force-pushed
the
extract-error-summary
branch
from
0a9784e
to
09a6bd8
Compare
fofr
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’d like to use this in email-alert-frontend
https://trello.com/c/HSre7K10/453-style-the-mvp-email-collection-page-needed-by-jan
Screenshot demonstrating the focus on page load: