Skip to content

Commit

Permalink
Center text and icons vertically in the option select component
Browse files Browse the repository at this point in the history
The font size of this element increased with the typography changes
deployed in a recent update to `govuk-frontend`. This means that the
up/down icons no longer align vertically. This PR makes a minor tweak
to the position of the icons for better vertical balance.

This also supports the same change made in `finder-frontend` where
search filter titles had the same tweak to icon positions. See the PR
at alphagov/finder-frontend#3334.
  • Loading branch information
matthillco committed Sep 30, 2024
1 parent 0f6b48d commit bdf6355
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

* Update accessibility criteria in component docs ([PR #4242](https://github.com/alphagov/govuk_publishing_components/pull/4242))
* Show all big_number symbol types in our docs ([PR #4271](https://github.com/alphagov/govuk_publishing_components/pull/4271))
* Center text and icons vertically in the option select component ([PR #4256](https://github.com/alphagov/govuk_publishing_components/pull/4256))

## 43.5.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
.gem-c-option-select__icon {
display: none;
position: absolute;
top: 0;
top: 3px;
left: 9px;
width: 30px;
height: 40px;
Expand Down

0 comments on commit bdf6355

Please sign in to comment.