Use shorthand lambda syntax #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinjam
force-pushed
the
use-lambda-shorthand
branch
from
0727d83
to
a66ca79
Compare
Fixes #341 `SimpleDelegator` was intercepting the `lambda` call via `method_missing`, and delegating to `Kernel#lambda`, passing the given block. This explodes on Ruby 3.3 because `lambda` only accepts block literals now. Replacing the `lambda` call with this shorthand syntax sidesteps the issue.
robinjam
force-pushed
the
use-lambda-shorthand
branch
from
a66ca79
to
52a0ebd
Compare
sengi
approved these changes
Jan 25, 2024
|
I'm pretty suspicious of the use of SimpleDelegator here (in the first place) but I suspect pulling on that string might lead to a much bigger refactor — so I think your fix is the right one at the right time. |
Agreed, I'm always a little wary of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341
SimpleDelegatorwas intercepting thelambdacall viamethod_missing, and delegating toKernel#lambda, passing the given block. This explodes on Ruby 3.3 becauselambdaonly accepts block literals now.Replacing the
lambdacall with this shorthand syntax sidesteps the issue. RuboCop is unhappy because it prefers the old syntax for multiline lambdas, so I've had to disable that cop.Tested locally against Content Data Admin.