Fix prometheus_exporter to method patching compatible with open telemetry #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation This switches prometheus_exporter's method patching to use `prepend` instead of `alias_method`. Prepend is negligibly slower than alias_method, but is more compatible other libraries.
theseanything
changed the title
sengi
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches prometheus_exporter's method patching to use
prependinstead ofalias_method. Prepend is negligibly slower than alias_method, but is more compatible other libraries.https://github.com/discourse/prometheus_exporter#choosing-the-style-of-method-patching
https://samsaffron.com/archive/2017/10/18/fastest-way-to-profile-a-method-in-ruby#fastest-way-to-patch-a-method-3
The issues with alias method cause a recursive call between prometheus_exporter and open telemetry sdk when making calls to SQL and redis.