Add Puma::HttpParserError to excluded exceptions #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sentry ruby 5.9 ensured that low level puma errors were captured [1] and propagated to sentry. This ended up in a lot of noise [2] in sentry when applications were bumped to this version of sentry ruby, particularly with Puma::HttpParser errors. These errors are often unactionable and we believe a result of crawler activity. This suppresses these errors in order to reduce sentry noise. 1: getsentry/sentry-ruby#2026 2: https://govuk.sentry.io/issues/4154286086/?project=202217
sihugh
approved these changes
May 10, 2023
MuriloDalRi
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HttpParserError to excluded exceptions
Sentry ruby 5.9 ensured that low level puma errors were captured and propagated to sentry. This ended up in a lot of noise [1] in sentry when applications were bumped to this version of sentry ruby, particularly with Puma::HttpParser errors.
These errors are often unactionable and we believe a result of crawler activity. This suppresses these errors in order to reduce sentry noise.
1: https://govuk.sentry.io/issues/4154286086/?project=202217