Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable EKS environment names for Sentry #260

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Enable EKS environment names for Sentry #260

merged 2 commits into from
Aug 19, 2022

Conversation

theseanything
Copy link
Contributor

This adds environment names for EKS versions of integration, staging and production.

sengi
sengi approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@sengi sengi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — I think we'll need these in order to tell easily between errors that are unique to one or other hosting environment vs common to both.

@sengi
Copy link
Contributor

sengi commented Aug 19, 2022 •
edited
Loading

I think you might need to add these here as well. Sorry scratch that — I appear to be losing the plot 😅

@theseanything
Enable EKS environment names for Sentry
e7cc368 
This adds environment names for EKS versions of integration, staging and production.
@theseanything
Bump version to 4.8.0
59a285f
@theseanything theseanything merged commit e3517c2 into main Aug 19, 2022
@theseanything theseanything deleted the eks-sentry-env-names branch August 19, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sengi sengi sengi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theseanything @sengi