Remove Speedcurve's LUX from connect-src policy
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alex-ju
approved these changes
Jan 31, 2022
injms
force-pushed
the
remove-lux-from-connect-src
branch
from
a6db8fc
to
dd3341f
Compare
|
Rebased against |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes the domain the LUX uses for reporting real user metrics from the
connect-srccontent security policy.Reverts #206.
Why
The domain was originally added because although an image was being used to report the metrics, the image was being served with a content type of
application/javascript. This meant the loading of the image was being blocked, which prevented any metrics from being reported.This rule can now be removed from the
connect-srcset of rules as the content type is nowimage/webp:and is allowed as the domain is in the
img-srcpolicy:govuk_app_config/lib/govuk_app_config/govuk_content_security_policy.rb
Lines 36 to 38 in a6db8fc