Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant role attributes #4854

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Remove redundant role attributes #4854

merged 4 commits into from
Mar 18, 2024

Commits on Mar 12, 2024

  1. Remove explicit role attributes where no longer needed

    These roles were included to help support older browsers that did not have the role implied by the HTML element.
    
    As we no longer support those browsers in Frontend, we can get rid of our explicit role attributes on the following elements:
    
    - the `banner` role on `header`
    - the `contentinfo` role on `footer`
    - the `main` role on `main`
    - the `navigation` role on `nav`
    - the `complementary` role on `aside`
    - the `region` role on `section`
    - the `article` role on `article`
    querkmachine committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    badceea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d370c5b View commit details
    Browse the repository at this point in the history
  3. Update html-validate rules

    Removes the `no-redundant-role` override. This now defaults to not allowing redundant `role` attributes.
    
    Adds an exception for `fieldset`s with a `role` of `group`, which we're choosing to maintain for assistive technology support.
    querkmachine committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    d876d84 View commit details
    Browse the repository at this point in the history
  4. Add changelog

    querkmachine committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4bfd65d View commit details
    Browse the repository at this point in the history