Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE11 vendor polyfills #3720

Merged
merged 5 commits into from
May 30, 2023
Merged

Remove IE11 vendor polyfills #3720

merged 5 commits into from
May 30, 2023

Conversation

domoscargin
Copy link
Contributor

@domoscargin domoscargin commented May 30, 2023

Partially addresses #2506

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3720 May 30, 2023 12:27 Inactive
@domoscargin
Copy link
Contributor Author

domoscargin commented May 30, 2023

Gzipped size of minified JS file:

Before: 9.3kB
After: 8kB

A few thoughts:

Intl API

There's some mentions of IE11 in the i18n's check for Plural Rules and Number Format support.

Can we simplify these checks to just look for .supportedLocalesOf and assume we're good on Intl and PluralRules/NumberFormat? Or do we need to keep these checks as is? @querkmachine - you probably have thoughts?

edit: see #2621 (comment)

Bits and bobs

There's a coupla things that come up when searching for "IE" (stuff like IE rendering in the template, potentially some html-validate rules, some specific fixes for components, etc.

Not sure we have anywhere to start logging these things to tackle as we go about the work of updating things?

Documentation

Should we just remove the polyfilling sections of our documentation?

@domoscargin domoscargin mentioned this pull request May 30, 2023
5 tasks
@domoscargin
Copy link
Contributor Author

Comment about non-vendored polyfills here: #2621 (comment)

@36degrees
Copy link
Contributor

There's some mentions of IE11 in the i18n's check for Plural Rules and Number Format support.

Can we simplify these checks to just look for .supportedLocalesOf and assume we're good on Intl and PluralRules/NumberFormat? Or do we need to keep these checks as is? @querkmachine - you probably have thoughts?

I find browsersl.ist really useful for looking at the intersection of support for these features and ES6 modules. For example, here's the browsers that support ES6 modules but don't support Intl.PluralRules.

Because that list isn't empty, we probably do need to keep the checks around for now. However, we do have an issue to remove the fallback 'polyfill' in a future 5.x release – we'll still need to keep the checks, but we can just fall back to the 'other' translation in the few older browsers that don't support it.

There's a coupla things that come up when searching for "IE" (stuff like IE rendering in the template, potentially some html-validate rules, some specific fixes for components, etc.

Not sure we have anywhere to start logging these things to tackle as we go about the work of updating things?

These are great catches! I reckon add comments to #2621 for now, like you have already for the various JS APIs? They seem unrelated to the polyfill changes in this PR.

@colinrotherham colinrotherham self-requested a review May 30, 2023 15:35
@domoscargin domoscargin changed the title Remove IE11 polyfills Remove IE11 vendor polyfills May 30, 2023
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3720 May 30, 2023 15:55 Inactive
@domoscargin
Copy link
Contributor Author

@colinrotherham I've updated polyfilling documentation and linked to #3722

@colinrotherham
Copy link
Contributor

@colinrotherham I've updated polyfilling documentation and linked to #3722

Nice, thanks @domoscargin. Keeps the git blame history going

@domoscargin domoscargin merged commit c36e5b9 into main May 30, 2023
@domoscargin domoscargin deleted the bk-remove-ie11-polyfills branch May 30, 2023 16:34
@romaricpascal romaricpascal mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants