Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2i-approved release notes content to changelog #2473

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Conversation

EoinShaughnessy
Copy link
Contributor

@EoinShaughnessy EoinShaughnessy commented Dec 13, 2021

Partly addresses #2314.

@EoinShaughnessy EoinShaughnessy added documentation User requests new documentation or improvements to existing documentation 🚀 release labels Dec 13, 2021
@EoinShaughnessy EoinShaughnessy self-assigned this Dec 13, 2021
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 13, 2021 11:48 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 13, 2021 11:53 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 13, 2021 12:06 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 13, 2021 13:41 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 13, 2021 14:08 Inactive
@EoinShaughnessy
Copy link
Contributor Author

@vanitabarrett Thanks for reviewing! I'm going to leave this PR open until the pre-i and 2i reviewers have also approved.

@36degrees Can we get a review? :)

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 13, 2021 15:37 Inactive
@EoinShaughnessy
Copy link
Contributor Author

Content sent for pre-i.

CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 08:27 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 08:28 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 09:28 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 09:30 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 09:55 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 10:50 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 11:52 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 12:09 Inactive
@EoinShaughnessy
Copy link
Contributor Author

Release notes have passed pre-i. Big thanks to @PippaClarkGDS for the helpful feedback! 🎉

Will now send notes for 2i.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 12:12 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 16:45 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 14, 2021 16:59 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 15, 2021 08:10 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 15, 2021 09:59 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 15, 2021 10:01 Inactive
@EoinShaughnessy EoinShaughnessy changed the title Update release notes draft with dev suggestions Create release notes for Frontend v4.0 Dec 15, 2021
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 15, 2021 13:45 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2473 December 15, 2021 13:49 Inactive
@EoinShaughnessy
Copy link
Contributor Author

Release notes have passed 2i. Thanks @cmcnallygds for the great review! 🎉

@EoinShaughnessy EoinShaughnessy changed the title Create release notes for Frontend v4.0 Add 2i-approved release notes content to changelog Dec 15, 2021
@EoinShaughnessy EoinShaughnessy merged commit 6eb6b2d into main Dec 15, 2021
@EoinShaughnessy EoinShaughnessy deleted the dev-changes branch December 15, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User requests new documentation or improvements to existing documentation 🚀 release
Projects
Development

Successfully merging this pull request may close these issues.

3 participants