Use tabular numbers for character count message #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default different numbers take up different amounts of horizontal space, for example ‘1’ is narrower than ‘0’, just like an ‘i’ is narrower than an ‘m’. This means that in the character count message the amount of space take up by the count varies as the user types. This causes the words after the count (‘characters remaining’) to jump around in a distracting way. Tabular numbers take up a fixed amount of space, which means the words after the count do not shift position while the count maintains the same number of digits.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2092
36degrees
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Thanks for this @quis – seems like a really sensible change and shows a great attention to detail 👍🏻 Would you mind adding an entry to the changelog?
Then we just need a second approval from someone else on the team and we can get this merged.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2092
|
Thanks @36degrees, I’ve updated the changelog in 7e75d73 |
vanitabarrett
approved these changes
Jan 11, 2021
Merged
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default different numbers take up different amounts of horizontal space, for example ‘1’ is narrower than ‘0’, just like an ‘i’ is narrower than an ‘m’.
In the character count component the amount of space take up by the message changes as the user types. This causes the words after the count (‘characters remaining’) to jump around in a distracting way.
Tabular numbers take up a fixed amount of space, which means the words after the count do not change position as long as the count maintains the same number of digits (which will be true for most keystrokes).
Before
After