Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modifiers for table captions #2048

Merged

Conversation

frankieroberto
Copy link
Contributor

This makes table captions consistent with fieldset legends and labels, in having modifiers which apply the typographic styles equivalent to headings.

Resolves issue 1405.

@36degrees 36degrees added the awaiting triage Needs triaging by team label Dec 1, 2020
@trang-erskine trang-erskine added 🕔 hours A well understood issue which we expect to take less than a day to resolve. table and removed awaiting triage Needs triaging by team labels Dec 7, 2020
Copy link
Contributor

@CharlotteDowns CharlotteDowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really good addition. I've left a few comments but you may have chosen to not do them intentionally based on the context. Let me know what you think and thanks again :).

src/govuk/components/table/_index.scss Show resolved Hide resolved
src/govuk/components/table/_index.scss Show resolved Hide resolved
src/govuk/components/table/_index.scss Show resolved Hide resolved
@36degrees
Copy link
Contributor

Do we need to update the Design System tables guidance to document these new classes?

@frankieroberto
Copy link
Contributor Author

@36degrees I think it makes sense to mention these options on the table component page?

I'd be tempted to make the default example on that page using a larger caption size too.

This makes table captions consistent with fieldset headings and labels, in having modifiers which apply the typographic styles equivalent to headings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve. table
Projects
Development

Successfully merging this pull request may close these issues.

Table caption styling is unclear
4 participants