Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling options to table header guidance #1448

Closed
wants to merge 1 commit into from

Conversation

CharlotteDowns
Copy link
Contributor

This is an update to the guidance to include the additional table styles created in pull request #2048

@govuk-design-system-ci
Copy link
Collaborator

✔️ You can preview this change here:

🔨 Explore the source changes: 55329b2

🔍 Inspect the deploy logs: https://app.netlify.com/sites/govuk-design-system-preview/deploys/5ffdae3f6fb4a70007bcf71c

😎 Browse the preview: https://deploy-preview-1448--govuk-design-system-preview.netlify.app

@@ -31,6 +31,8 @@ Use the `<caption>` element to describe a table in the same way you would use a

Use table headers to tell users what the rows and columns represent. Use the `scope` attribute to help users of assistive technology distinguish between row and column headers.

There are other styling options for table headers, you can apply other classes to make them larger than default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right – table headers are (confusingly!) the cells in a table that act as headers for a row or column.

Whereas the styles added in alphagov/govuk-frontend#2048 are designed to be used on table captions, which are mentioned in the previous section.

I wonder if we also need to list out what the classes are, and give at least one example?

Happy to pair with you on this, if that'd be helpful.

@36degrees 36degrees linked an issue Jan 27, 2021 that may be closed by this pull request
2 tasks
@CharlotteDowns
Copy link
Contributor Author

Closing this pull request as it is now being covered in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants