Skip to content

Commit

Permalink
Bump minimum Node version, allow using npm v10
Browse files Browse the repository at this point in the history
Node 18.19.0 updated the npm dependency to version 10.2.3. https://nodejs.org/en/blog/release/v18.19.0

This would break fresh builds of Frontend v4 as a user would automatically get the latest Node 18 version but simultaneously get an npm
version not in our allowed range.

Additionally increases the minimum Node version	to 18.17.0, as this is the earliest version of Node still supported by npm 10.x.
  • Loading branch information
querkmachine committed Jan 4, 2024
1 parent 92462b3 commit d481607
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 25 deletions.
4 changes: 2 additions & 2 deletions app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "GOV.UK Frontend review app",
"main": "src/start.mjs",
"engines": {
"node": "^18.12.0",
"npm": "^8.1.0 || ^9.1.0"
"node": "^18.17.0",
"npm": "^8.1.0 || ^9.1.0 || ^10.1.0"
},
"license": "MIT",
"scripts": {
Expand Down
26 changes: 13 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"name": "govuk-frontend-repository",
"description": "Used only for the development of GOV.UK Frontend, see `package/package.json` for the published `package.json`",
"engines": {
"node": "^18.12.0",
"npm": "^8.1.0 || ^9.1.0"
"node": "^18.17.0",
"npm": "^8.1.0 || ^9.1.0 || ^10.1.0"
},
"license": "MIT",
"workspaces": [
Expand Down
4 changes: 2 additions & 2 deletions shared/config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "GOV.UK Frontend shared config",
"main": "index.js",
"engines": {
"node": "^18.12.0",
"npm": "^8.1.0 || ^9.1.0"
"node": "^18.17.0",
"npm": "^8.1.0 || ^9.1.0 || ^10.1.0"
},
"license": "MIT",
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions shared/helpers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"./*": "./*.js"
},
"engines": {
"node": "^18.12.0",
"npm": "^8.1.0 || ^9.1.0"
"node": "^18.17.0",
"npm": "^8.1.0 || ^9.1.0 || ^10.1.0"
},
"license": "MIT",
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions shared/lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"./*": "./*.js"
},
"engines": {
"node": "^18.12.0",
"npm": "^8.1.0 || ^9.1.0"
"node": "^18.17.0",
"npm": "^8.1.0 || ^9.1.0 || ^10.1.0"
},
"license": "MIT",
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions shared/tasks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "GOV.UK Frontend shared tasks",
"main": "index.mjs",
"engines": {
"node": "^18.12.0",
"npm": "^8.1.0 || ^9.1.0"
"node": "^18.17.0",
"npm": "^8.1.0 || ^9.1.0 || ^10.1.0"
},
"license": "MIT",
"devDependencies": {
Expand Down

0 comments on commit d481607

Please sign in to comment.