Skip to content

Commit

Permalink
Merge pull request #3559 from alphagov/remove-ie8-css
Browse files Browse the repository at this point in the history
Remove IE8–10 related Sass and CSS build tasks
  • Loading branch information
querkmachine authored May 3, 2023
2 parents 1593117 + d736de5 commit 8586ba4
Show file tree
Hide file tree
Showing 54 changed files with 166 additions and 1,063 deletions.
5 changes: 1 addition & 4 deletions .browserslistrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,8 @@ last 2 Firefox versions
last 2 Edge versions
last 2 Samsung versions
Safari >= 9
ie 9-11
ie 11
iOS >= 9

[oldie]
ie 8

[node]
node 18
4 changes: 0 additions & 4 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ updates:
- dependency-type: direct

ignore:
# Ignore major updates (breaks IE8 PostCSS plugins)
- dependency-name: autoprefixer
update-types: ['version-update:semver-major']

# Always ignore legacy packages
- dependency-name: iframe-resizer
- dependency-name: jquery
Expand Down
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ Instead we recommend checking for the disabled attribute using [`$button.hasAttr

This change was introduced in [pull request #2830: Set the boolean disabled attribute consistently in the button component](https://github.com/alphagov/govuk-frontend/pull/2830).

#### Remove Internet Explorer 8 stylesheets, settings and mixins

We no longer support Internet Explorer 8 (IE8) in GOV.UK Frontend and no longer provide dedicated stylesheets for the browser. Remove any references to these stylesheets from your HTML.

We've removed the `govuk-if-ie8` and `govuk-not-ie8` mixins, and the `$govuk-is-ie8` and `$govuk-ie8-breakpoint` settings, that were deprecated in [GOV.UK Frontend v4.6.0](https://github.com/alphagov/govuk-frontend/releases/tag/v4.6.0).

This change was introduced in [pull request #3559: Remove IE8-related Sass and CSS build tasks](https://github.com/alphagov/govuk-frontend/pull/3559).

#### Remove deprecated `.govuk-button--disabled` class

We've removed the `.govuk-button--disabled` class that we deprecated in [GOV.UK Frontend v4.6.0](https://github.com/alphagov/govuk-frontend/releases/tag/v4.6.0).
Expand All @@ -32,6 +40,14 @@ We no longer support link buttons being disabled or using disabled styles.

This change was introduced in [pull request #3557: Remove deprecated `.govuk-button--disabled` class](https://github.com/alphagov/govuk-frontend/pull/3557).

#### Update the HTML for warning text

We've removed the `.govuk-warning-text__assistive` class and its styles from GOV.UK Frontend. This class is unnecessary, as it duplicates the functionality of the `.govuk-visually-hidden` class already present in Frontend.

If you’re not using Nunjucks macros, update your warning text HTML to replace the `govuk-warning-text__assistive` class with the `govuk-visually-hidden` class.

This change was introduced in [pull request #3569: Remove unnecesary class from Warning Text component](https://github.com/alphagov/govuk-frontend/pull/3569).

## 4.6.0 (Feature release)

### New features
Expand Down
116 changes: 0 additions & 116 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@
"postcss-load-config": "^4.0.1",
"postcss-pseudo-classes": "^0.2.1",
"postcss-scss": "^4.0.6",
"postcss-unmq": "^1.0.2",
"postcss-unopacity": "^2.0.0",
"postcss-unrgba": "^1.1.1",
"prettier": "^2.8.8",
"puppeteer": "^19.11.1",
"sassdoc": "^2.7.4",
Expand Down Expand Up @@ -109,15 +106,6 @@
"latest-version@^5": {
"package-json": "^7"
},
"postcss-unmq": {
"postcss": "^7"
},
"postcss-unopacity": {
"postcss": "^7"
},
"postcss-unrgba": {
"postcss": "^7"
},
"sass-convert": {
"semver-regex": "^3"
},
Expand Down
3 changes: 0 additions & 3 deletions packages/govuk-frontend-review/src/stylesheets/app-ie8.scss

This file was deleted.

26 changes: 0 additions & 26 deletions packages/govuk-frontend-review/src/stylesheets/app-legacy-ie8.scss

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,11 @@
width: 100%;
clear: both;
box-shadow: 0 0 0 5px $app-preview-border-colour;

@include _govuk-if-ie8 {
outline: 5px solid $app-preview-border-colour;
}
}
}

// Removes the breakpoint sass-mq debug display
.app-iframe-in-component-preview:before {
.app-iframe-in-component-preview::before {
display: none;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,7 @@
{% from "checkboxes/macro.njk" import govukCheckboxes %}

{% block head %}
<!--[if !IE 8]><!-->
<link rel="stylesheet" href="/stylesheets/app.min.css">
<!--<![endif]-->
<!--[if IE 8]>
<link rel="stylesheet" href="/stylesheets/app-ie8.min.css">
<![endif]-->
<link rel="stylesheet" href="/stylesheets/app.min.css">
<!--[if lt IE 9]>
<script src="/vendor/html5-shiv/html5shiv.min.js"></script>
<![endif]-->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@

{% block head %}
<!-- block:head -->
<!--[if !IE 8]><!-->
<link rel="stylesheet" href="/stylesheets/app.min.css">
<!--<![endif]-->
<!--[if IE 8]>
<link rel="stylesheet" href="/stylesheets/app-ie8.min.css">
<![endif]-->
<link rel="stylesheet" href="/stylesheets/app.min.css">
<!--[if lt IE 9]>
<script src="/vendor/html5-shiv/html5shiv.min.js"></script>
<![endif]-->
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
{% extends "template.njk" %}

{% block head %}
<!--[if !IE 8]><!-->
<link rel="stylesheet" href="/stylesheets/app.min.css">
<!--<![endif]-->
<!--[if IE 8]>
<link rel="stylesheet" href="/stylesheets/app-ie8.min.css">
<![endif]-->
<link rel="stylesheet" href="/stylesheets/app.min.css">
<!--[if lt IE 9]>
<script src="/vendor/html5-shiv/html5shiv.min.js"></script>
<![endif]-->
Expand Down
14 changes: 2 additions & 12 deletions packages/govuk-frontend-review/src/views/layouts/_generic.njk
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,9 @@
<![endif]-->
<link rel="stylesheet" media="print" href="/vendor/govuk_template/stylesheets/govuk-template-print.css">
<link rel="stylesheet" media="all" href="/vendor/govuk_template/stylesheets/fonts.css"/>
<!--[if !IE 8]><!-->
<link rel="stylesheet" href="/stylesheets/app-legacy.min.css">
<!--<![endif]-->
<!--[if IE 8]>
<link rel="stylesheet" href="/stylesheets/app-legacy-ie8.min.css">
<![endif]-->
<link rel="stylesheet" href="/stylesheets/app-legacy.min.css">
{% else %}
<!--[if !IE 8]><!-->
<link rel="stylesheet" href="/stylesheets/app.min.css">
<!--<![endif]-->
<!--[if IE 8]>
<link rel="stylesheet" href="/stylesheets/app-ie8.min.css">
<![endif]-->
<link rel="stylesheet" href="/stylesheets/app.min.css">
{% endif %}

{% block styles %}{% endblock %}
Expand Down
7 changes: 1 addition & 6 deletions packages/govuk-frontend-review/src/views/layouts/legacy.njk
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,7 @@
{% block cookie_message %}<p>GOV.UK uses cookies to make the site simpler. <a href="https://www.gov.uk/help/cookies">Find out more about cookies</a></p>{% endblock %}

{% block head %}
<!--[if !IE 8]><!-->
<link rel="stylesheet" href="/stylesheets/app-legacy.min.css">
<!--<![endif]-->
<!--[if IE 8]>
<link rel="stylesheet" href="/stylesheets/app-legacy-ie8.min.css">
<![endif]-->
<link rel="stylesheet" href="/stylesheets/app-legacy.min.css">
{% endblock %}

{% block body_start %}
Expand Down
14 changes: 0 additions & 14 deletions packages/govuk-frontend/src/govuk/all-ie8.scss

This file was deleted.

Loading

0 comments on commit 8586ba4

Please sign in to comment.