Move detailed guides to new layout #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
force-pushed
the
move-detailed-guides-to-new-layout
branch
from
ad1e77c
to
d8ae1c0
Compare
|
Nice to see the removal of that "Too much detail" box. |
fofr
reviewed
Jan 18, 2018
| guides.map { |g| { text: g["title"], path: g["base_path"] } } | ||
| end | ||
|
|
||
|
|
fofr
reviewed
Jan 18, 2018
| <%= render 'govuk_component/title', @content_item.title_and_context %> | ||
| <%= render 'govuk_component/title', | ||
| title: @content_item.title, | ||
| average_title_length: "long" %> |
There was a problem hiding this comment.
No context is being passed here, so the title is missing the grey "Guidance" text above the title.
fofr
reviewed
Jan 18, 2018
| items: @content_item.metadata[:other] %> | ||
|
|
||
| <%= render "components/contents-list-with-body", contents: @content_item.contents do %> | ||
| <%# if @content_item.related_mainstream_content.any? %> |
There was a problem hiding this comment.
Commented block still needed?
There was a problem hiding this comment.
Should also delete the .related-mainstream-content styles
fofr
reviewed
Jan 18, 2018
test/test_helper.rb
Outdated
| else | ||
| assert page.has_text?(value[:text]) | ||
| assert page.has_text?(value[:text]), "Metadata value '#{value[:text]}' not found" |
|
What happened to the grey borders around the metadata?
|
steventux
force-pushed
the
move-detailed-guides-to-new-layout
branch
from
d8ae1c0
to
87c6bd6
Compare
steventux
force-pushed
the
move-detailed-guides-to-new-layout
branch
from
87c6bd6
to
3fb0d2d
Compare
steventux
force-pushed
the
move-detailed-guides-to-new-layout
branch
from
3fb0d2d
to
4a892b1
Compare
steventux
force-pushed
the
move-detailed-guides-to-new-layout
branch
from
4a892b1
to
6df3afc
Compare
steventux
force-pushed
the
move-detailed-guides-to-new-layout
branch
from
9ff4409
to
d5ef44b
Compare
steventux
force-pushed
the
move-detailed-guides-to-new-layout
branch
from
d5ef44b
to
8337d90
Compare
1 task
steventux
force-pushed
the
move-detailed-guides-to-new-layout
branch
from
8337d90
to
3e0dc55
Compare
steventux
force-pushed
the
move-detailed-guides-to-new-layout
branch
from
3e0dc55
to
97c5a5a
Compare
jon-kirwan
added a commit
that referenced
this pull request
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/uScvU8q2/189-add-detailedguide-to-universal-layout
Depends on alphagov/govuk-content-schemas#706
(PR number jinx!)
Example
https://government-frontend-pr-706.herokuapp.com/guidance/classifying-vehicles
Before
After
Component guide for this PR:
https://government-frontend-pr-706.herokuapp.com/component-guide