Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rails 7.2.1 #3741

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Upgrade to rails 7.2.1 #3741

merged 3 commits into from
Sep 25, 2024

Conversation

beccapearce
Copy link
Contributor

@beccapearce beccapearce commented Aug 20, 2024 •
edited
Loading

@govuk-ci govuk-ci temporarily deployed to collections-pr-3741 August 20, 2024 10:15 Inactive
@beccapearce beccapearce marked this pull request as ready for review September 2, 2024 16:22
@beccapearce beccapearce changed the title Upgrade to rails 7.2 Upgrade to rails 7.2.1 Sep 2, 2024
@unoduetre
Copy link
Contributor

I removed the icons from my PRs. Do you want to keep them?

unoduetre
unoduetre requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@unoduetre unoduetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments. Please, let me know what you think.

config/application.rb Outdated Show resolved Hide resolved
config/environments/development.rb Outdated Show resolved Hide resolved
config/environments/production.rb Outdated Show resolved Hide resolved
config/initializers/filter_parameter_logging.rb
Rails.application.config.filter_parameters += %i[
passw secret token _key crypt salt certificate otp ssn
passw email secret token _key crypt salt certificate otp ssn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should add email to that, but if you're ok with that, that's fine.

unoduetre
unoduetre approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@unoduetre unoduetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@beccapearce beccapearce merged commit 70b2b5f into main Sep 25, 2024
14 checks passed
@beccapearce beccapearce deleted the upgrade-to-rails-7.2 branch September 25, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unoduetre unoduetre unoduetre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beccapearce @unoduetre @govuk-ci