Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for attachment meta steps #2107

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Add support for attachment meta steps #2107

merged 1 commit into from
Sep 23, 2023

Conversation

baev
Copy link
Member

@baev baev commented Sep 11, 2023

Context

Due to limitations of the Allure 2 Model, attachments are always rendered at the end of the execution item. For example, the following code

await allure.logStep("step 1");
await allure.attachment("some data", "content", "text/plain");
await allure.logStep("step 2");

will show in the report:

  1. step 1
  2. step 2
  3. some data

To workaround the issue, users may wrap attachments in steps, e.g. by adding @Step annotation on top of @Attachment method. However, such an approach will create redundant steps in the report. This pull request is fixing that, removing an extra step from the report.

Screenshot 2023-09-11 at 15 05 58

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:plugin api theme:ui type:new feature Change that add something new for end users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants