This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Fix logrus go mod mess #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ultimately caused by logrus being imported with inconsistent casing. Some packages in our deps haven’t caught up to go modules and the canonical (enforced) casing. Longer term, I’d recommend we try to eliminate those dependencies since they’re most likely unmaintained projects. |
ckarenz
approved these changes
Mar 14, 2019
|
|
||
| exclude github.com/Sirupsen/logrus v1.1.1 | ||
|
|
||
| exclude github.com/Sirupsen/logrus v1.1.0 |
There was a problem hiding this comment.
Should these be grouped/sorted similarly to requirements below in order to minimize diff churn?
There was a problem hiding this comment.
go mod tidy seems to want to inject the spaces...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the root issue was that
go mod tidywas failing withgo: github.com/Sirupsen/logrus@v1.4.0: parsing go.mod: unexpected module path "github.com/sirupsen/logrus".This should effectively fix the above issue. Seems to work in local testing.