This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Add flag for exposing session ports. #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `--port` flag to the `beaker session create` command.
katepanter
reviewed
Apr 21, 2022
| cmd.Flags().Float64Var(&cpus, "cpus", 0, "Minimum CPU cores to reserve, e.g. 7.5") | ||
| cmd.Flags().IntVar(&gpus, "gpus", 0, "Minimum number of GPUs to reserve") | ||
| cmd.Flags().StringVar(&memory, "memory", "", "Minimum memory to reserve, e.g. 6.5GiB") | ||
| cmd.Flags().StringVar(&sharedMemory, "shared-memory", "", "Shared memory (size of /dev/shm), e.g. 1GiB") | ||
| cmd.Flags().StringSliceVar( |
There was a problem hiding this comment.
thanks for the roadmap for adding preemptible to beaker flags :)
schmmd
approved these changes
Apr 21, 2022
| @@ -178,6 +185,17 @@ To pass flags, use "--" e.g. "create -- ls -l"`, | |||
| }) | |||
| } | |||
|
|
|||
| var tcpPorts []api.TCPPort | |||
| for _, p := range ports { | |||
| pp, err := strconv.ParseInt(p, 10, 32) | |||
There was a problem hiding this comment.
lol, I love that go has 3 parameters for ParseInt.
There was a problem hiding this comment.
Yea, setting the bit size was surprising. Particularly when the type that's returned is int.
It'd be nice if it were a separate function, say, strconv.ParseInt32(). That way the returned type could be int32 and I wouldn't have to cast/convert things in code. But of course blows out the stdlib a bit. It's tricky!
/shrug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
--portflag to thebeaker session createcommand.
This codebase doesn't have any tests. So I tested manually. I started
a local executor, then build a local
beakerCLI and started a sessionlike so:
This worked! The
docker pscommand shows the container, with a random portbound to container port
8888:I tested invalid ports (overflow, 0, etc). Everything seemed to work.
https://github.com/allenai/beaker-service/issues/2009