Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Commit

Permalink
Group detail tweaks (#75)
Browse files Browse the repository at this point in the history
  • Loading branch information
aaasen committed May 11, 2018
1 parent d641906 commit a1bd783
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
11 changes: 10 additions & 1 deletion ui/src/group/details/GroupDetailsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,17 @@ import { Switch, Route, Redirect } from 'react-router-dom';
import GroupComparisonTabContainer from './comparison/GroupComparisonTabContainer';
import GroupDescription from './GroupDescription';
import GroupName from './GroupName';
import CircleSpinner from '../../components/CircleSpinner.jsx';

export interface GroupDetailsPageProps { loggedInUser: User; group: Group; }

export const GroupDetailsPage = (props: GroupDetailsPageProps) => {
if (!props.group) {
return <None/>;
return (
<CircleSpinner>
Loading group...
</CircleSpinner>
);
}

const baseURL = '/gr2/' + props.group.id;
Expand All @@ -28,6 +33,10 @@ export const GroupDetailsPage = (props: GroupDetailsPageProps) => {
<GroupName group={props.group}/>

<GroupDescription/>

<div className="attribution">
Created by: {props.group.user.name}
</div>
</div>

<GroupTabs experimentsURL={experimentsURL} comparisonsURL={comparisonsURL} />
Expand Down
2 changes: 2 additions & 0 deletions ui/src/group/details/GroupTabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ const GroupTabs = (props: Props) => {
Comparisons
</NavLink>

{/*
<NavLink
to={props.experimentsURL}
className="tab"
activeClassName="tab-active">
Experiments
</NavLink>
*/}
</div>
);
};
Expand Down
4 changes: 2 additions & 2 deletions ui/src/less/group.less
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@
}

.group-header {
.editable-text {
margin-bottom: 30px;
.attribution {
margin-bottom: 16px;
}

.loader-svg {
Expand Down

0 comments on commit a1bd783

Please sign in to comment.