Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hedron_compile_commands module to support compile_commands.json #384

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

chloro-pn
Copy link
Collaborator

@chloro-pn chloro-pn commented Jul 20, 2024

chore(bazel) and refactor:

  • add hedron_compile_commands module to support compile_commands.json;
  • remove unused header files according to clangd's prompts;
  • use async_simple::coro::CoroHandle

Why

What is changing

No incompatible changes

Example

bazel run @hedron_compile_commands//:refresh_all -- --action_env=CXX=clang++ --action_env=CC=clang --define ASYNC_SIMPLE_DISABLE_AIO=true

…ort compile_commands.json; remove unused header files; use async_simple::coro::CoroHandle"
@chloro-pn chloro-pn force-pushed the add_hedron_compile_commands branch 3 times, most recently from caee857 to 28a45c6 Compare July 20, 2024 16:12
MODULE.bazel Outdated
module_name = "hedron_compile_commands",
remote = "https://github.com/hedronvision/bazel-compile-commands-extractor.git",
commit = "1e08f8e0507b6b6b1f4416a9a22cf5c28beaba93",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new line

@@ -6,3 +6,12 @@ bazel_dep(name = "bazel_skylib", version = "1.6.1")
bazel_dep(name = "googletest", version = "1.14.0.bcr.1", repo_name = "com_google_googletest", dev_dependency = True)
bazel_dep(name = "google_benchmark", version = "1.8.4", repo_name = "com_google_benchmark", dev_dependency = True)
bazel_dep(name = "boringssl", version = "0.0.0-20240530-2db0eb3", dev_dependency = True)

# Hedron's Compile Commands Extractor for Bazel
# https://github.com/hedronvision/bazel-compile-commands-extractor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write the usage instructions in README

@chloro-pn chloro-pn requested a review from 4kangjc July 21, 2024 08:38
Copy link
Collaborator

@ChuanqiXu9 ChuanqiXu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChuanqiXu9
Copy link
Collaborator

I'd like to land this. If there are following update or requests, we can make it in following commits.

@ChuanqiXu9 ChuanqiXu9 merged commit 6ee73d3 into alibaba:main Jul 22, 2024
14 checks passed
@chloro-pn chloro-pn deleted the add_hedron_compile_commands branch July 23, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants