修复 #3138: SystemRuleManager 保留原始 SystemRule 信息 #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sczyh30
added
the
kind/enhancement
|
Thanks for contributing. Could you please add some test cases for it? PS: It's relevant to changes of the underlying model of SystemRuleManager. I've created an issue for it: #3148 |
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
[BUG] 系统规则失效 SystemSlot 检测未通过抛出SystemBlockException，但是在LogSlot e.getRule().getId() 由于SystemSlot 抛出的异常没有rule导致 发生NullPointerException， 导致没有收到 BlockedException
完善 #2851 的逻辑闭环
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews