Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(envoy-rls): Update sentinel-cluster-server-envoy-rls to support v3 api #2336

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

winjaychan
Copy link
Contributor

@winjaychan winjaychan commented Aug 13, 2021

Update sentinel-cluster-server-envoy-rls to support envoy v2 and v3 api. See #2156 for the enhancement demand

Add envoy v3 api implementation.
Make it to be compatible with envoy v2 api.
Add k8s envoy v3 api demo.

Describe what this PR does / why we need it

Update sentinel-cluster-server-envoy-rls to support envoy v3 api

Does this pull request fix one issue?

#2156

Describe how you did it

Describe how to verify it

Run the test cases and demo.

Special notes for reviews

…envoy v2 and v3 api.

Add envoy v3 api implementation.
Make it to be compatible with envoy
v2
api.
Add k8s envoy v3 api demo.
@CLAassistant
Copy link

CLAassistant commented Aug 13, 2021

CLA assistant check
All committers have signed the CLA.

@winjaychan winjaychan changed the title feat(envoy-rls): Update sentinel-cluster-server-envoy-rls to support … feat(envoy-rls): Update sentinel-cluster-server-envoy-rls to support v3 api Aug 13, 2021
update the README.md for document-lint check
@sczyh30 sczyh30 added area/cloud-native Issues or PRs related to cloud native architecture area/cluster-flow Issues or PRs related to cluster flow control kind/enhancement Category issues or prs related to enhancement. to-review To review labels Aug 14, 2021
@sczyh30 sczyh30 self-requested a review August 14, 2021 04:20
@sczyh30 sczyh30 added the size/XL Indicate a PR that changes 500-999 lines. label Aug 16, 2021
@sczyh30 sczyh30 linked an issue Aug 16, 2021 that may be closed by this pull request
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 27514f0 into alibaba:master Aug 20, 2021
@sczyh30 sczyh30 removed the to-review To review label Aug 20, 2021
@sczyh30 sczyh30 added this to the 1.8.3 milestone Aug 20, 2021
@sczyh30
Copy link
Member

sczyh30 commented Aug 20, 2021

Nice work. Thanks for contributing and look forward to more!

Zhang-0952 pushed a commit to Zhang-0952/Sentinel that referenced this pull request Mar 4, 2022
…en server module (alibaba#2336)

* feat(envoy-rls): Update sentinel-cluster-server-envoy-rls to support envoy v2 and v3 api.

* Add envoy v3 api implementation; Make it to be compatible with envoy v2 API.
* Add k8s envoy v3 api demo.
* docs(envoy-rls): update the README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cloud-native Issues or PRs related to cloud native architecture area/cluster-flow Issues or PRs related to cluster flow control kind/enhancement Category issues or prs related to enhancement. size/XL Indicate a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update sentinel-cluster-server-envoy-rls to envoy v3 api
3 participants