[Fixes #1065]modified sentinel-dubbo-adapter module DefaultDubboFallback.java class,resolve the issue #1065 [Serialized class com.alibaba.csp.sentinel.slots.block.flow.FlowRule must implement java.io.Serializable] #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….java class,resolve the issue #1065 [Serialized class com.alibaba.csp.sentinel.slots.block.flow.FlowRule must implement java.io.Serializable]
| // Just wrap the exception. | ||
| return new RpcResult(new SentinelRpcException(ex)); | ||
| // Just wrap the exception. edit by wzg923 2020/9/23 | ||
| RpcResult result = new RpcResult(); |
There was a problem hiding this comment.
please reformat the code
sczyh30
added
the
area/integrations
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
* pid 4bytes * pid is 4 bytes * alibaba#1751 fix bug and add a unit test * alibaba#1751 short pid * 保持原来 * alibaba#1751 remove repeat code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
fixed the bug of sentinel-dubbo-adapter [Caused by: java.lang.RuntimeException: Serialized class com.alibaba.csp.sentinel.slots.block.flow.FlowRule must implement java.io.Serializable]
Does this pull request fix one issue?
Fixes #1065
Describe how you did it
Just wrap the BlockException to a custom RuntimeException,so the result do not contains the BlockException.
Describe how to verify it
Verify it by run the example project of sentinel-demo-dubbo .
Special notes for reviews