Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nacos-client version to 1.3.0 in sentinel-datasource-nacos #1574

Closed
sczyh30 opened this issue Jun 30, 2020 · 4 comments · Fixed by #1576
Closed

Upgrade nacos-client version to 1.3.0 in sentinel-datasource-nacos #1574

sczyh30 opened this issue Jun 30, 2020 · 4 comments · Fixed by #1576
Labels
area/data-source Issues or PRs related to data-source extension dependencies Pull requests that update a dependency file good first issue Good for newcomers

Comments

@sczyh30
Copy link
Member

sczyh30 commented Jun 30, 2020

Issue Description

Type: dependency update

Describe what happened (or what feature you want)

Upgrade nacos-client version to 1.3.0 in sentinel-datasource-nacos.
@sczyh30 sczyh30 added good first issue Good for newcomers dependencies Pull requests that update a dependency file area/data-source Issues or PRs related to data-source extension labels Jun 30, 2020
@RGaius
Copy link
Contributor

RGaius commented Jun 30, 2020

Only need to upgrade the version in pom？

@sczyh30
Copy link
Member Author

sczyh30 commented Jun 30, 2020

Only need to upgrade the version in pom？

You may also need to do regression tests to verify the dependency update.

@RGaius
Copy link
Contributor

RGaius commented Jun 30, 2020

Only need to upgrade the version in pom？

You may also need to do regression tests to verify the dependency update.

Ok, i will finish it

@sczyh30 sczyh30 linked a pull request Jul 1, 2020 that will close this issue
feat: Upgrade nacos-client version to 1.3.0 #1576
Merged
@sczyh30
Copy link
Member Author

sczyh30 commented Jul 1, 2020

Resolved via #1576

@sczyh30 sczyh30 closed this as completed Jul 1, 2020
CST11021 pushed a commit to CST11021/Sentinel that referenced this issue Nov 3, 2021
@ShadowySpirits
[ISSUE alibaba#1574] change GET_ROUTEINTO_BY_TOPIC to GET_ROUTEINFO_B…
bca05f7 
…Y_TOPIC

[ISSUE alibaba#1574] change GET_ROUTEINTO_BY_TOPIC to GET_ROUTEINFO_BY_TOPIC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/data-source Issues or PRs related to data-source extension dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Upgrade nacos-client version to 1.3.0 RGaius/Sentinel
2 participants
@sczyh30 @RGaius