Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antd proV5引入DonutChart后切换路由报错:Failed to execute 'unobserve' on 'ResizeObserver' #1365

Closed
Elric-H opened this issue Feb 5, 2021 · 7 comments

Comments

@Elric-H
Copy link

Elric-H commented Feb 5, 2021

BizCharts Version:4.1.6
react Version:17.0.0
image
是不是因为DonutChart组件内没有清理 resizeObserver?

@millievn
Copy link
Contributor

millievn commented Feb 6, 2021

@Elric-H 我也遇到了 有解决方案么

@smddzcy
Copy link

smddzcy commented Feb 6, 2021

I get the same error on all kinds of charts, so it's not just DonutChart. I think this issue is introduced with the 4.1.6 version, I'm downgrading to 4.1.5 now to check.

edit: Confirming that we're not getting this error on version 4.1.5.

@millievn
Copy link
Contributor

millievn commented Feb 6, 2021

@smddzcy i find one reason and i make a pull request before your comment. i will check what happened after v3.1.5

@smddzcy
Copy link

smddzcy commented Feb 6, 2021

@qiwang97 sorry, I actually meant "4.1.5". This whole block of code was added in 4.1.6, so that's what happened after 4.1.5 😄

image

Your fix looks good to me, let's hope that it gets merged quickly.

@millievn
Copy link
Contributor

millievn commented Feb 6, 2021

@smddzcy i find one reason and i make a pull request before your comment. i will check what happened after v3.1.5

@smddzcy I make a diff and you can see the changes.

@Elric-H
Copy link
Author

Elric-H commented Feb 7, 2021

@Elric-H 我也遇到了 有解决方案么

目前还没解决方案,实在不行只有换回3.4.0了...

Leannechn added a commit that referenced this issue Feb 7, 2021
fix(DonutChart): fix unobserve error #1365
@Leannechn
Copy link
Contributor

pr 已发布 4.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants