fix: moves AlgoSDK ENG-366 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashMapsData2Value
changed the title
HashMapsData2Value
changed the title
PhearZero
reviewed
May 22, 2024
This reverts commit 4491505.
HashMapsData2Value
changed the title
HashMapsData2Value
changed the title
HashMapsData2Value
added a commit
that referenced
this pull request
May 22, 2024
* fix: replaces AlgoSDK with Bip39 library * Revert "fix: replaces AlgoSDK with Bip39 library" This reverts commit 4491505. * fix: move AlgoSDK dependent components over into Demo
github-actions bot
pushed a commit
to PhearZero/liquid-auth-android
that referenced
this pull request
May 29, 2024
# 1.0.0-beta.1 (2024-05-29) ### Bug Fixes * moves AlgoSDK ENG-366 ([algorandfoundation#8](https://github.com/PhearZero/liquid-auth-android/issues/8)) ([c162474](c162474)) * signaling event names ([cf5e5e9](cf5e5e9)) ### Features * add answer client and offer activity ([2538e53](2538e53)) * add credential provider service and activities ([35ebb37](35ebb37)) * add credential provider service and activities ([819759f](819759f)) * add datachannel message types ([6af393a](6af393a)) * add fido2 package ([c12fb0f](c12fb0f)) * add logo to qr-code ([49602bb](49602bb)) * handle FIDO intent ([e8a35ad](e8a35ad)) * handle FIDO intent ([8aedb03](8aedb03)) * initialize and add verify package ([4658456](4658456)) * liquid deep-links ([354ee32](354ee32)) * liquid uri schema support ([61b175f](61b175f)) * webrtc signalling ([cda74a6](cda74a6))
github-actions bot
pushed a commit
to PhearZero/liquid-auth-android
that referenced
this pull request
May 29, 2024
# 1.0.0 (2024-05-29) ### Bug Fixes * moves AlgoSDK ENG-366 ([algorandfoundation#8](https://github.com/PhearZero/liquid-auth-android/issues/8)) ([c162474](c162474)) * signaling event names ([cf5e5e9](cf5e5e9)) ### Features * add answer client and offer activity ([2538e53](2538e53)) * add credential provider service and activities ([35ebb37](35ebb37)) * add credential provider service and activities ([819759f](819759f)) * add datachannel message types ([6af393a](6af393a)) * add fido2 package ([c12fb0f](c12fb0f)) * add logo to qr-code ([49602bb](49602bb)) * handle FIDO intent ([e8a35ad](e8a35ad)) * handle FIDO intent ([8aedb03](8aedb03)) * initialize and add verify package ([4658456](4658456)) * liquid deep-links ([354ee32](354ee32)) * liquid uri schema support ([61b175f](61b175f)) * webrtc signalling ([cda74a6](cda74a6))
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
# 1.0.0-canary.1 (2024-06-19) ### Bug Fixes * **demo:** add all trusted browsers ([a98cfe3](a98cfe3)) * moves AlgoSDK ENG-366 ([#8](#8)) ([c162474](c162474)) * signaling event names ([cf5e5e9](cf5e5e9)) * **SignalService:** consolidate notifications ([83a0359](83a0359)) ### Features * add answer client and offer activity ([2538e53](2538e53)) * add credential provider service and activities ([35ebb37](35ebb37)) * add credential provider service and activities ([819759f](819759f)) * add datachannel message types ([6af393a](6af393a)) * add fido2 package ([c12fb0f](c12fb0f)) * add logo to qr-code ([49602bb](49602bb)) * handle FIDO intent ([e8a35ad](e8a35ad)) * handle FIDO intent ([8aedb03](8aedb03)) * initialize and add verify package ([4658456](4658456)) * liquid deep-links ([354ee32](354ee32)) * liquid uri schema support ([61b175f](61b175f)) * **SignalClient:** allow color configuration for qrCode ([fa2c479](fa2c479)) * **SignalClient:** pass in iceServers as an optional parameter to the peer method ([6082fda](6082fda)) * **SignalService:** SignalService ([06949ad](06949ad)) * webrtc signalling ([cda74a6](cda74a6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't want to use AlgoSDK but presumably still to be able to pass in a mnemonic this replaces it with Bip39, the same as the one we have in our ARC-52 Bip32-Ed25519-Kotlin library.
Note that Bip39 is typically used with 24 words and so providing 25 words, or any mnemonic phrase that does not validate (against the checksum), will fail.
Note also that it is the mnemonics entropy is used as an input into FixedSecureRandom, it is not the seed.