Do not msgpack empty leases. #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lease of 32 zeros should not be msgpacked, or we get signature errors, as the Go code does not pack it. Check and remove such leases at Transaction construction time.
|
@jannotti thanks for working on this. Can you also extend this to work for the |
|
Sure. I meant to look into that and check metadata rules. |
This doesn't change functionality, but makes it more clear that lease and metadata_hash are handled the same way. Must be 32 bytes, all zero bytes is equivalent to not being present. We should think about how to handle the Zero address, when specified for rekey or close_to. I believe it should be handled similarly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lease of 32 zeros should not be msgpacked, or we get signature
errors, as the Go code does not pack it. Check and remove such leases
at Transaction construction time.