Remove Buffer Usage
#801
Merged
Remove Buffer Usage
#801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
commented
Jul 20, 2023
| @@ -49,7 +49,7 @@ async function main() { | |||
| console.log(`Asset Params: ${JSON.stringify(assetInfo.params)}`); | |||
| // example: ASSET_INFO | |||
|
|
|||
| await new Promise((f) => setTimeout(f, 2000)); // sleep to ensure indexer is caught up | |||
| await new Promise((f) => setTimeout(f, 5000)); // sleep to ensure indexer is caught up | |||
There was a problem hiding this comment.
This looks frequently flaky on CI, but I haven't seen it fail locally 👀
jasonpaulos
reviewed
Jul 26, 2023
There was a problem hiding this comment.
I think we'd also want to remove the dependency on the 3rd party buffer package to consider #734 complete. Do you plan to do that in this PR?
Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
Eric-Warehime
approved these changes
Jul 27, 2023
jasonpaulos
reviewed
Jul 27, 2023
Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
jasonpaulos
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to remove
Bufferusage in JS SDK:Bufferusage to node environmentUint8ArraySome extra changes:
asaexampleCloses #734