Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Min fee sp fix #760

Merged
merged 7 commits into from
Apr 6, 2023
Merged

BugFix: Min fee sp fix #760

merged 7 commits into from
Apr 6, 2023

Conversation

barnjamin
Copy link
Contributor

@barnjamin barnjamin commented Apr 5, 2023 •
edited
Loading

Closes #750

@barnjamin barnjamin changed the title Min fee sp fix BigFix: min fee sp fix Apr 5, 2023
@barnjamin barnjamin changed the title BigFix: min fee sp fix BugFix: min fee sp fix Apr 5, 2023
jasonpaulos
jasonpaulos approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking my suggestion.

Just one inconsequential nit

tests/10.ABI.ts Outdated Show resolved Hide resolved
algochoi
algochoi approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, like the backward compatible change

@barnjamin barnjamin merged commit 71dea9f into algorand:develop Apr 6, 2023
@onetechnical onetechnical changed the title BugFix: min fee sp fix BugFix: Min fee sp fix May 8, 2023
@onetechnical onetechnical mentioned this pull request May 8, 2023
Merged
@Eric-Warehime Eric-Warehime mentioned this pull request May 23, 2023
Closed
@OKEAMAH OKEAMAH mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

@algochoi algochoi algochoi approved these changes

Assignees
No one assigned
Labels
Bug-Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing min-fee on Suggested params
3 participants
@barnjamin @jasonpaulos @algochoi