bugfix: Satisfy typescript constraints #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related issue #638 |
barnjamin
changed the title
algochoi
approved these changes
Feb 13, 2023
jasonpaulos
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was using js algosdk as part of a ts npm package that relies on https://www.npmjs.com/package/dts-bundle-generator for bundle generation. The main dependency was beaker-ts (which relies on algosdk) client however dts bundler revealed tiny ts related errors that had to be addressed to properly transpile the code. Refer to screens below describing the errors that were addressed.
Proposed changes
Further notes
I will rely on the forked version of the repo in the meantime