Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Migrate v1 algod dependencies to v2 in cucumber tests #693

Merged
merged 8 commits into from
Nov 23, 2022

Conversation

algochoi
Copy link
Contributor

Migrates algod v1 tests to use v2.

SDK Testing PR: algorand/algorand-sdk-testing#249

.test-env Outdated Show resolved Hide resolved
@algochoi algochoi marked this pull request as ready for review November 21, 2022 15:54
@ahangsu ahangsu self-requested a review November 22, 2022 16:16
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks correct to me, and the test is passing, generally looks good. Only one question about first round and last round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants