Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-order box args to avoid breaking changes #660

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Re-order box args to avoid breaking changes #660

merged 2 commits into from
Sep 26, 2022

Conversation

jasonpaulos
Copy link
Contributor

Child PR to #604

Changes the order of arguments to avoid introducing a breaking change with the new box arguments.

algochoi
algochoi approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jasonpaulos jasonpaulos merged commit 4026bf5 into feature/box-storage Sep 26, 2022
@jasonpaulos jasonpaulos deleted the make-txn-box-arg-order branch September 26, 2022 16:33
@jasonpaulos jasonpaulos mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algochoi algochoi algochoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonpaulos @algochoi