Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Boxes Indexer Integration test #641

Merged
merged 14 commits into from
Sep 15, 2022

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Sep 7, 2022

No description provided.

@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch from 347042e to 85641b8 Compare September 8, 2022 19:11
.test-env Outdated Show resolved Hide resolved
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch 5 times, most recently from afaac2d to 7211d3d Compare September 9, 2022 21:47
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch from 7211d3d to 9713f8f Compare September 12, 2022 16:06
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch from 7409af5 to 7e2a62b Compare September 12, 2022 16:51
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically approvable but waiting on decision for future of tag @applications.boxes_indexer_confirmed

Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzaffi
Copy link
Contributor

tzaffi commented Sep 14, 2022

LGTM

LEBTM

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

tests/cucumber/steps/steps.js Outdated Show resolved Hide resolved
…nd/js-algorand-sdk into ahangsu/indexer-integration-boxes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a reminder for the other assert.fails

tests/cucumber/steps/steps.js Outdated Show resolved Hide resolved
tests/cucumber/steps/steps.js Outdated Show resolved Hide resolved
…nd/js-algorand-sdk into ahangsu/indexer-integration-boxes
…nd/js-algorand-sdk into ahangsu/indexer-integration-boxes
@ahangsu ahangsu merged commit b45e83c into feature/box-storage Sep 15, 2022
@ahangsu ahangsu deleted the ahangsu/indexer-integration-boxes branch September 15, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants