Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Removing more unused steps #637

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented Aug 30, 2022

Remove 3 additional unused steps

  1. When: I create the payment transaction
  2. Given: 'key registration transaction parameters {int} {int} {int} {string} {string} {string} {int} {int} {int} {string} {string}'
  3. When: I create the key registration transaction

@tzaffi tzaffi changed the title Some more unused steps Enhanced: Removing more unused steps Aug 30, 2022
@tzaffi tzaffi changed the title Enhanced: Removing more unused steps Enhancement: Removing more unused steps Aug 31, 2022
@tzaffi tzaffi closed this Aug 31, 2022
@tzaffi tzaffi reopened this Aug 31, 2022
@tzaffi tzaffi closed this Aug 31, 2022
@tzaffi tzaffi reopened this Aug 31, 2022
@tzaffi tzaffi merged commit 00afcd3 into develop Aug 31, 2022
@tzaffi tzaffi deleted the some-more-unused-steps branch August 31, 2022 15:47
ahangsu added a commit that referenced this pull request Sep 3, 2022
* bump version and add to changelog

* update README.md for new version

* prettier on CHANGELOG

* Update README.md

Co-authored-by: John Lee <john.lee@algorand.com>

* Update README.md

Co-authored-by: John Lee <john.lee@algorand.com>

* Enhancement: Use sandbox for SDK Testing and remove Indexer v1 steps (#623)

* Add files to enable sandbox sdk testing

* Add some todo comments and formatting

* Update changes to script and env

* Delete indexer v1 test steps

* More changes to cucumber tests

* Change features directory in JS SDK

* Remove more indexer integration tests

* Update test env

* Update test-harness.sh

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Break out cucumber tags into their own files (#625)

* Command to generate input for Unused Steps Analysis Script + Remove those steps (#627)

* command to generate input for Unused Steps Analysis Script + Remove those steps

* remvoe the steps

* In response to CR remark. Update Makefile

* Update .test-env

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Bugfix: Pass verbosity to the harness and sandbox (#630)

* Ignore algorand-sdk-testing test-harness dir (#634)

* Enhancement: Deprecating use of langspec (#632)

* enhancement: Initial stateproofs support (#629)

* Initial stateproofs support

* Some more unused steps (#637)

* dummy push

* revert change of dummy push, ci runs now

Co-authored-by: Barbara Poon <barbara.poon@algorand.com>
Co-authored-by: algobarb <78746954+algobarb@users.noreply.github.com>
Co-authored-by: John Lee <john.lee@algorand.com>
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants