Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dist directory #326

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Remove dist directory #326

merged 2 commits into from
Mar 29, 2021

Conversation

jdtzmn
Copy link
Contributor

@jdtzmn jdtzmn commented Mar 26, 2021 •
edited
Loading

This PR removes the dist directory from version control and includes instructions for finding previous assets.

Some tasks that will need to be done in the future:

  • Add documentation for the publishing process. This will largely depend on how releases are published in the future.
  • Include a link to a CDN in the README.md right before new releases have been published.

Closes #324.

@jdtzmn
Remove dist directory
2031909 
* Include directions in README for downloading previous web bundles
@jdtzmn
Add dist to .gitignore and .dockerignore
6699671
@jdtzmn jdtzmn marked this pull request as ready for review March 26, 2021 16:31
jasonpaulos
jasonpaulos approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jdtzmn jdtzmn merged commit 661b540 into develop Mar 29, 2021
@jdtzmn jdtzmn deleted the jacob/delete-dist-folder branch March 29, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete the dist folder
2 participants
@jdtzmn @jasonpaulos