decodeAddress now verifies the checksum (fixes #262) #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fixes readme;
jasonpaulos
suggested changes
Jan 21, 2021
There was a problem hiding this comment.
Thanks for implementing this @Neurone, this looks great! Could you add a test in tests/3.Address.js to verify decodeAddress throws an error when given an address with an invalid checksum (probably with assert.throws(...))? I'd be happy to accept once that's added.
|
Hi @jasonpaulos, sure. I'll send an update during this weekend. |
jasonpaulos
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed also an npm command in readme
Fixes #262