Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Application Boxes in Indexer #1168

Merged
merged 56 commits into from
Nov 1, 2022
Merged

New Feature: Application Boxes in Indexer #1168

merged 56 commits into from
Nov 1, 2022

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented Aug 9, 2022

Integration branch where "ready to merge" box-related code will live until go-algorand box code is itself merged.

TODO before merging

  • Has go-algorand's feature/avm-box been merged?
  • End-to-end test
    • is passing against network that includes boxes
    • has been re-pointed to rel-nightly once that job includes boxes
    • .circleci/config.yml's CI_E2E_FILENAME has been reverted
  • Re-point the third_party/go-algorand submodule to
    • go-algorand
    • a released commit containing boxes

Co-authored-by: Will Winder <wwinder.unh@gmail.com>
Co-authored-by: shiqi.zheng@algorand.com <shiqi.zheng@algorand.com>
Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
Co-authored-by: AlgoStephenAkiki <85183435+AlgoStephenAkiki@users.noreply.github.com>
Co-authored-by: John Jannotti <jannotti@gmail.com>
@tzaffi tzaffi marked this pull request as draft August 9, 2022 15:05
@tzaffi tzaffi changed the title New Feature: Application Boxes New Feature: Application Boxes in Indexer Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1168 (acec7c4) into develop (95658bc) will increase coverage by 1.25%.
The diff coverage is 73.46%.

@@             Coverage Diff             @@
##           develop    #1168      +/-   ##
===========================================
+ Coverage    61.11%   62.36%   +1.25%     
===========================================
  Files           52       52              
  Lines         8512     8843     +331     
===========================================
+ Hits          5202     5515     +313     
+ Misses        2848     2827      -21     
- Partials       462      501      +39     
Impacted Files Coverage Δ
api/error_messages.go 100.00% <ø> (ø)
api/generated/common/routes.go 46.51% <ø> (ø)
api/server.go 61.84% <ø> (ø)
idb/dummy/dummy.go 0.00% <0.00%> (ø)
idb/idb.go 69.35% <ø> (ø)
idb/postgres/internal/encoding/types.go 66.66% <ø> (ø)
idb/postgres/internal/writer/util.go 100.00% <ø> (ø)
idb/sig_type.go 64.00% <0.00%> (ø)
idb/postgres/internal/writer/writer.go 85.64% <64.00%> (-1.58%) ⬇️
api/handlers.go 75.42% <70.73%> (-0.29%) ⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

misc/docker-compose.yml Outdated Show resolved Hide resolved
misc/e2elive.py Outdated Show resolved Hide resolved
misc/docker-compose.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spurious space

.circleci/config.yml Outdated Show resolved Hide resolved
@tzaffi tzaffi merged commit be89f75 into develop Nov 1, 2022
@tzaffi tzaffi deleted the integration/boxes branch November 1, 2022 17:43
winder pushed a commit to winder/indexer that referenced this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants