-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): Visually group suggestions together #72
Conversation
By analyzing the blame information on this pull request, we identified @pixelastic and @redox to be potential reviewers |
@@ -62,6 +66,7 @@ | |||
// The secondary column is hidden on small screens | |||
.algolia-docsearch-suggestion--subcategory-column { | |||
display: none; | |||
cursor: default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it's such a good idea to remove the cursor: pointer
on something clickable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to disable the click using pointer-events: none;
but didn't work. I guess we'd need to disable in the JS by checking if the parent of the click elements if different from the left column.
For now when a user click it redirect to the page of suggestion that is at the same level as the mouse. And not to the sub-category, like the user could expect.
💯 |
fix(dropdown): Visually group suggestions together
Currently, clicks on the dropdown are intercepted by the js and "manually" redirect to the destination. This means that |
I haven't, I don't correctly handle Ctrl+clicks on Zendesk either.
|
In the current version, each row in the left column (display sub categories) are separated with a line, even when two suggestions belong to the same sub-category.
Removing those, and making the interlines lighter in the right column, improves readability.
Makes it easier for the brain to understand that some items belong to a same sub-category.
Also disabled the mouse hover look'n'feel when hovering the left column.