Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): Visually group suggestions together #72

Merged
merged 1 commit into from
Jan 30, 2016

Conversation

seafoox
Copy link
Member

@seafoox seafoox commented Jan 29, 2016

In the current version, each row in the left column (display sub categories) are separated with a line, even when two suggestions belong to the same sub-category.

screenshot 2016-01-29 16 16 21

Removing those, and making the interlines lighter in the right column, improves readability.
Makes it easier for the brain to understand that some items belong to a same sub-category.

screenshot 2016-01-29 16 15 40

Also disabled the mouse hover look'n'feel when hovering the left column.

@algobot
Copy link

algobot commented Jan 29, 2016

By analyzing the blame information on this pull request, we identified @pixelastic and @redox to be potential reviewers

@@ -62,6 +66,7 @@
// The secondary column is hidden on small screens
.algolia-docsearch-suggestion--subcategory-column {
display: none;
cursor: default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's such a good idea to remove the cursor: pointer on something clickable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to disable the click using pointer-events: none; but didn't work. I guess we'd need to disable in the JS by checking if the parent of the click elements if different from the left column.

For now when a user click it redirect to the page of suggestion that is at the same level as the mouse. And not to the sub-category, like the user could expect.

@Jerska
Copy link
Member

Jerska commented Jan 29, 2016

💯

pixelastic added a commit that referenced this pull request Jan 30, 2016
fix(dropdown): Visually group suggestions together
@pixelastic pixelastic merged commit 93e7316 into algolia:develop Jan 30, 2016
@pixelastic
Copy link
Contributor

Currently, clicks on the dropdown are intercepted by the js and "manually" redirect to the destination. This means that ctrl+click does not work. We'll have to fix this. I think @jerskouille worked on something similar already?

@Jerska
Copy link
Member

Jerska commented Feb 1, 2016

I haven't, I don't correctly handle Ctrl+clicks on Zendesk either.
However, in instantsearch.js we solved that with links, we could try something like:

  • have links in the markup to handle clicks + control clicks
  • have the autocomplete:selected.event return if it's a click, and redirect as before if it's with the keyboard
    I'm not sure how to detect it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants