Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default hitsPerPage not applied if algoliaOptions are specified #78

Closed
redox opened this issue Mar 9, 2016 · 0 comments
Closed

Default hitsPerPage not applied if algoliaOptions are specified #78

redox opened this issue Mar 9, 2016 · 0 comments
Assignees
Labels

Comments

@redox
Copy link
Contributor

redox commented Mar 9, 2016

As soon as you specify some algoliaOptions, we lose the default hitsPerPage value. Would be better to keep that value as a default.

@redox redox added the bug label Mar 9, 2016
redox added a commit that referenced this issue Mar 9, 2016
While overriding the algoliaOptions, we were losing the default
hitsPerPage query parameters.

Fix #78
@redox redox self-assigned this Mar 9, 2016
@redox redox closed this as completed in b284dda Mar 16, 2016
redox added a commit that referenced this issue Mar 16, 2016
<a name="1.1.1"></a>
## [1.1.1](v1.1.0...v1.1.1) (2016-03-16)

### Bug Fixes

* **algoliaOptions:** ensure we keep default options ([b284dda](b284dda)), closes [#78](#78)
* **autocomplete:** auto select top result ([473824a](473824a)), closes [#81](#81)
* **dev:** Fixed the dev example, targeting an existing index ([df13e34](df13e34))
* **website:** responsive logo ([b856d67](b856d67))

### Features

* **serve:** Add `npm run serve` to expose js and css locally ([31e5d13](31e5d13))
* **website:** community header ([366cc0d](366cc0d))
* **website:** Logo Update - Og screen + favicon ([c7eb54a](c7eb54a))
* **website:** removed demos ([6d8eb34](6d8eb34))
* **website:** update ([9498e3b](9498e3b))
* **website:** updated logo ([fa413d9](fa413d9))
acodereviewersbestfriend52 added a commit to acodereviewersbestfriend52/docsearch that referenced this issue Aug 3, 2024
<a name="1.1.1"></a>
## [1.1.1](algolia/docsearch@v1.1.0...v1.1.1) (2016-03-16)

### Bug Fixes

* **algoliaOptions:** ensure we keep default options ([506a8a3](algolia/docsearch@506a8a3)), closes [#78](algolia/docsearch#78)
* **autocomplete:** auto select top result ([86ffdd9](algolia/docsearch@86ffdd9)), closes [#81](algolia/docsearch#81)
* **dev:** Fixed the dev example, targeting an existing index ([5483cfc](algolia/docsearch@5483cfc))
* **website:** responsive logo ([ee28f5b](algolia/docsearch@ee28f5b))

### Features

* **serve:** Add `npm run serve` to expose js and css locally ([ce3b679](algolia/docsearch@ce3b679))
* **website:** community header ([de54982](algolia/docsearch@de54982))
* **website:** Logo Update - Og screen + favicon ([abcf633](algolia/docsearch@abcf633))
* **website:** removed demos ([9551f3c](algolia/docsearch@9551f3c))
* **website:** update ([2835549](algolia/docsearch@2835549))
* **website:** updated logo ([26bc736](algolia/docsearch@26bc736))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants
@redox and others