Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get volume function #66

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Add get volume function #66

merged 4 commits into from
Apr 6, 2024

Conversation

Liborsaf
Copy link
Contributor

@Liborsaf Liborsaf commented Apr 3, 2024

No description provided.

@alexmohr
Copy link
Owner

alexmohr commented Apr 6, 2024

Thanks for the contribution. I removed travis and added github ci instead. In turn I had to fix some new linter warnings, so you have to fix some conflicts now. Sorry :/
Also please add a unit test for the new method

@Liborsaf
Copy link
Contributor Author

Liborsaf commented Apr 6, 2024

Thanks for the contribution. I removed travis and added github ci instead. In turn I had to fix some new linter warnings, so you have to fix some conflicts now. Sorry :/ Also please add a unit test for the new method

No problem, will look into that in few minutes :)

@Liborsaf
Copy link
Contributor Author

Liborsaf commented Apr 6, 2024

Not very experienced in doing unit tests, so hopefully this is good :D

Copy link
Owner

@alexmohr alexmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the test is good just one more minor finding and then this is good to go :)

sonyapilib/device.py Outdated Show resolved Hide resolved
@Liborsaf Liborsaf requested a review from alexmohr April 6, 2024 21:33
@alexmohr alexmohr merged commit 5a1ee58 into alexmohr:master Apr 6, 2024
3 checks passed
@alexmohr alexmohr mentioned this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants