builder: Add a set_rdev() convenience #377
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commonly one may be building tar archives from the filesystem in a custom way, or operating on a translation of a non-tar format which uses rdev, not split major/minor. Today one needs to replicate the nontrivial bit manipulations to split the device; but since we have that code anyways in our own "build from filesystem" code, let's just add it as a public API. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
rdev-majorminor
branch
from
8722550
to
c8b7972
Compare
|
Hum right, |
|
Took me awhile to get here, but seems reasonable to me! I think there's still some compilation issues though? |
|
Yeah this needs some more work; not at all urgent. I'll unmark it as draft when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commonly one may be building tar archives from the filesystem in a custom way, or operating on a translation of a non-tar format which uses rdev, not split major/minor.
Today one needs to replicate the nontrivial bit manipulations to split the device; but since we have that code anyways in our own "build from filesystem" code, let's just add it as a public API.