Add FTP maximum limit for concurrent transfers #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldostools
approved these changes
Aug 18, 2022
aldostools
added a commit
that referenced
this pull request
Aug 18, 2022
- Compiled binaries for pull-request #764 submitted by @kostirez1 - Fixed compilation errors in ftp.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements global limit for concurrent FTP transfers. For now, limits are hardcoded, but could become user configurable in the future. This also doesn't impose limit on control connections itself - it's possible to issue non RETR/STOR commands even if the limit has been reached.
MAX_TRANSFERS = 2seems to be a good tradeoff between large amount of small files speed and small amount of large files, as there isn't an infinite HDD throughput anyways - large transfers have to compete for resources on system calls.Transfers that are over the
MAX_TRANSFERSstay in a queue until either:(Part of #760 FTP improvements.)