-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mounting /app_home #1074
fix mounting /app_home #1074
Conversation
(i only tested it on HEN 3.3.0, not sure if it works on CFW) |
@bibarub Thank you for your pull request. I have applied almost all your changes, except the removal of the multi-disc logic. I added comments explaining how it works. Maybe you didn't get how the logic works. I tested it on CFW some years ago. If the code is broken as you mentioned in your comments, it needs to be fixed not removed 😃 |
sorry, didn't think about that at all xD. thank you for merging the code by the way, change '18' to '11' at line 941 in include/mount/mount.h. the 7 extra bytes were used for "/USRDIR", which we don't touch anymore also, you forgot to change the comment at line 921 in the same file |
regarding the multi-disc code |
@bibarub Thank you for your comments and for the PR. The suggested corrections were applied. If you have additional improvements or find bugs, feel free to let me know. Best regards!! I'm closing this PR, since I merged the changes directly . |
Yes. This DisgeaTriplePlayCollectionFilelist.txt is supposed to be the directory structure from the multi-game disc "Disgea Trilogy Collection" . I obtained it from this post https://www.psx-place.com/threads/make-multidisc-ps3-game.41758/ Current code seems to cycle only from PS3_GM01 to PS3_GM99, ignoring PS3_GAME if they exist. I think the line 947 should be changed to Anyway this only affect noBD consoles that require mount JB games through /app_home. /dev_bdvd show multi-game discs in separated disc icons. |
webMAN didn't mount /app_home correctly (it was mounting USRDIR to /app_home. i don't know the reason behind this, but it does not work at all), this commit fixes it
USRDIR-related code has been removed from both map_app_home and set_app_home, the multidisc logic from map_app_home has been commented out (it's completely broken), the conditions in set_app_home have been edited a bit