-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How can i declare an auto_delete exchange #218
Comments
It looks like those parameters were disabled in codegen.py for reasons unknown to me (before I took maintainership of the project, likely it wasn't enabled on the broker side). I'll consider making this a part of the function signature. The workaround is to do what that function does in your own code and set the auto_delete parameter to something other than 1 to enable it. |
Thank you very much, I will set auto_delete = 1 to enable it . |
Enable auto_delete and internal parameters of amqp_exchange_declare() in codegen. These were once not generated because RabbitMQ did not support these parameters. The broker now supports these and so should we. This fixes #218
Commit 9626dd5 breaks BC. Actually, fixing errors is good, but it would be nice to note about BC breakage in next release notes. Thanks for a great work! |
I am aware that this is an API and an ABI break. I do add these sorts of changes to the change log when I create a release. That said, if your build process relies on building from HEAD, you're going to run into issues like this from time to time. Your best bet is to build from a tagged release. |
Yeah, building from releases is the best option. I do so, but one of php-amqp user found that issue so I just curious whether BC is broken by-design or it just bug. For php-amqp it would not be a problem to check framing version and make a tiny wrapped in macro to deal with such kind of changes. |
In amqp_framing.c has this function:
In this function req.auto_delete = 0;
How can I declare an auto_delete exchange? Thanks.
The text was updated successfully, but these errors were encountered: