Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brightness reading in nightlight mode #1276

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

detecti1
Copy link
Contributor

  yeelink.light.ceiling8
  yeelink.light.ceiling12
  yeelink.light.ceiling13
  yeelink.light.ceiling14

Fixed the issue where brightness readings for the mentioned model of lights were incorrect after enabling moonlight mode. #1070

I made changes only to the device model that I could test and confirm. Uncertain whether these changes apply to other models as well.

修复上述型号的灯在启用月光模式后亮度读数不正确的问题

只修改了我可以测试的并确认工作正常的设备型号,不确定是否还有其他型号也适用。

Copy link
Owner

@al-one al-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献!

  • 建议直接修改ceiling6
  • nl_br可以通过'miio_props': ['nl_br']直接获取,无需miio_commands
  • prop.2.2应该还需要set_template来控制夜灯模式下的亮度

@detecti1
Copy link
Contributor Author

好的,前两点我稍后修改一下。

最后那个 prop.2.2 亮度设置问题,在我的修改后的测试中以及之前提的 issue 中都有提到,目前的设置方式一切行为都符合预期(日光/月光模式下设置这个值都可以正常调整当前模式亮度,并且不影响另外一个模式的亮度记忆,也不会导致模式切换),是否这个就不改了?

@al-one
Copy link
Owner

al-one commented Aug 24, 2023

是的,看来在日光和夜光模式下设置亮度的命令是一样的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants