Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rn, fix eslint, ts errors #1655

Merged
merged 11 commits into from
Nov 4, 2022
Merged

update rn, fix eslint, ts errors #1655

merged 11 commits into from
Nov 4, 2022

Conversation

AndreiPirovich
Copy link
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

updated react-native to 0.69.5, fixed eslint, ts errors

greenfrvr
greenfrvr reviewed Oct 17, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@AndreiPirovich AndreiPirovich force-pushed the feat/update-rn-version branch 2 times, most recently from f15afd3 to 5c1508e Compare October 31, 2022 09:02
greenfrvr
greenfrvr reviewed Oct 31, 2022
View reviewed changes
src/showcases/components/styled/styledComponentVariants.component.tsx Outdated
import { Interaction, styled } from '@ui-kitten/components';
import { EvaProp, Interaction, styled } from '@ui-kitten/components';

interface IProps {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename non-exportable interface to Props. According to our styleguide we avoid I prefixes

@greenfrvr greenfrvr linked an issue Oct 31, 2022 that may be closed by this pull request
Support React Version 18 and React Native 0.69 (latest), especially in conjunction with expo SDK 46. #1640
Closed
@greenfrvr greenfrvr merged commit b8ca73b into master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenfrvr greenfrvr greenfrvr approved these changes

@malashkevich malashkevich Awaiting requested review from malashkevich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support React Version 18 and React Native 0.69 (latest), especially in conjunction with expo SDK 46.
2 participants
@AndreiPirovich @greenfrvr